bug/WG-449-Success-toast-with-error-msg

[sophia-massie]

Overview:

Bug - success toast with error message when importing an asset to a feature with no asset

PR Status:

• Ready.
• Work in Progress.
• Hold.

Related Jira tickets:

• WG-449

Summary of Changes:

• Fixed notification.success for onError state
• Angular/ Hazmapper prod allowed pngs assets to features but didn't actually work and import failed.
  • Removed this because geoapi doesn't allow png imports. See createFeatureAsset in geoapi/services/features.py. Geoapi will always return "Invalid format for feature assets" error message. Was png imports on prod ever working? Was this intended to work?

Testing Steps:

1. On your own map, create a feature with no asset. Try importing geojson data from GEOAPI Test do not edit project
2. Try importing a png file. Go to published data in file browser -> select PRJ - 1972 -> select San_Jac2.png and make sure that import is disabled.
3. Check that png is no longer listed in the Allowed file types at the top of the modal
4. Check code to see where there was a copy + paste error that told notification to show success style notification when error
5. If you want to check what the error notification will look like, add png back to the Importable_feature_asset_types in fileUtils and try and import the same San_Jac2.png.

UI Photos:

Notes:

[nathanfranklin]

LGTM. 👍

---

Was png imports on prod ever working?
Was this intended to work?

good catch on this. Now, I doubt it was ever working.

I was curious if our current workflow would "just work" for pngs as we aren't trying to read the jpg-only exif in this case. But it currently currently fails for converting png to jpeg using Pillow (OSError: cannot write mode RGBA as JPEG). so I assume that means it never worked.