task/WG-432 rework hooks, maps and feature tree to minimize renders #339
+534
−309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hanges-filter-changes
…hanges-filter-changes
…hanges-filter-changes
…hanges-filter-changes
Moving functions out of the render cycle and into memoized component properties. Changes account for feature selection time from 700ms to 20ms
Prevent unnecessary re-renders by removing searchParams dependency as selectedFeatureId is enough. Also useMemo for selectedFeatureId determination
Ensure that setSelectedFeatureID is not dependent on selectedFeatureId
Make some optimizations in Map and FeatureFileTree
nathanfranklin
requested review from
rstijerina,
shayanaijaz and
sophia-massie
rstijerina
approved these changes
Feb 28, 2025
| const { height, ref } = useResizeDetector(); | ||
| const { height: rawHeight, ref } = useResizeDetector({ | ||
| refreshMode: 'debounce', | ||
| refreshRate: 50, // Small debounce to avoid initial extreme values seen on comonent remount |
There was a problem hiding this comment.
Suggested change
| refreshRate: 50, // Small debounce to avoid initial extreme values seen on comonent remount | |
| refreshRate: 50, // Small debounce to avoid initial extreme values seen on component remount |
Comment on lines
+150
to
+154
| const prevDataRef = useRef<FeatureCollection | undefined>(undefined); | ||
| const prevStateRef = useRef<{ pending: boolean; error: boolean }>({ | ||
| pending: false, | ||
| error: false, | ||
| }); |
There was a problem hiding this comment.
Just curious, I wonder if react query's keepPreviousData could be of use here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
This PR reworked hooks, maps and feature tree to minimize renders and optimize things.
The main issues we noticed were:
The fixes were:
useCurrentFeatureshook so that provides stable reference to the latest featuresuseFeatureSelectionhook to ensure that setSelectedFeatureID is not dependent on selectedFeatureIdOff-topic change:
PR Status:
Related Jira tickets:
Summary of Changes:
Testing Steps:
Notes:
TODO