Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/wp 312 view users pagination #229

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mjames-uth
Copy link
Collaborator

@mjames-uth mjames-uth commented Oct 9, 2023

Overview

This is the first round in integrating the API into the apcd-cms project. This required a custom paginator that could interact with the API.

To use:
1.Pull branch
2. Update the secrets file with the following code: APCD_API_URL = 'http://XX.XX.XX.XX'
This IP should be to the API making sure there is no forward slash / at the end

Related

Changes

Custom API Paginator - is built on top of the current django paginator. It takes only a subset of data, but still calculates page numbers and size correctly.
ADMIN > View User - The View Users page was used to demonstrator how the paginator works and that it works correctly

Testing

Confirm all of the same functionality exists on the View Users Page

  1. View Users Page Loads
  2. Paging Works - Correct Number of Pages
  3. Filter by Active/Inactive Status
  4. Filter by Orgs
  5. View Record
  6. Edit Record

UI

Copy link
Contributor

@sophia-massie sophia-massie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was mistaken review

Copy link
Contributor

@sophia-massie sophia-massie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants