Skip to content

Commit

Permalink
chore: move page_attribute "page_title" to base
Browse files Browse the repository at this point in the history
There is no reason to do this on every template.

I had continued doing it, because I feared breaking things.

I know enough about the templates now to know repition was unnecessary.
  • Loading branch information
wesleyboar committed Aug 29, 2023
1 parent e043d45 commit 9e892c6
Show file tree
Hide file tree
Showing 6 changed files with 2 additions and 10 deletions.
2 changes: 1 addition & 1 deletion taccsite_cms/templates/base.html
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
{% include 'analytics.html' %}

<!-- Metadata. -->
<title>{% block title %} This is my new project home page {% endblock title %}</title>
<title>{% block title %}{% page_attribute "page_title" %}{% endblock title %}</title>
<meta charset="utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">

Expand Down
2 changes: 0 additions & 2 deletions taccsite_cms/templates/fullwidth.html
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
{% extends "base.html" %}
{% load cms_tags %}

{% block title %}{% page_attribute "page_title" %}{% endblock title %}

{# To remove container and breadcrumbs #}
{% block content %}
{% placeholder "content" %}
Expand Down
2 changes: 0 additions & 2 deletions taccsite_cms/templates/sidebar_left.html
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
{% extends "base.html" %}
{% load cms_tags %}

{% block title %}{% page_attribute "page_title" %}{% endblock title %}

{% block assets_custom %}
{{ block.super }}

Expand Down
2 changes: 0 additions & 2 deletions taccsite_cms/templates/sidebar_right.html
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
{% extends "base.html" %}
{% load cms_tags %}

{% block title %}{% page_attribute "page_title" %}{% endblock title %}

{% block assets_custom %}
{{ block.super }}

Expand Down
2 changes: 0 additions & 2 deletions taccsite_cms/templates/standard.html
Original file line number Diff line number Diff line change
@@ -1,4 +1,2 @@
{% extends "base.html" %}
{% load cms_tags %}

{% block title %}{% page_attribute "page_title" %}{% endblock title %}
2 changes: 1 addition & 1 deletion taccsite_custom

0 comments on commit 9e892c6

Please sign in to comment.