Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: GH-101: Match Portal+Docs Nav Breakpoint #247

Conversation

wesleyboar
Copy link
Member

Overview

Make CMS match Portal & Docs navbar collapse breakpoint.

Caveat: This makes a stand-alone CMS navbar collapse for a wider screen than it did before (and than is necessary). For CMS's that have a Portal, there is no change.

Changes

  • New/Fix: Use navbar-expand-lg (for now) to match Portal & Docs.

Testing

  • Load Docs, CMS, and Portal.
  • Ensure all three have the same navbar styling and collapsing at these breakpoints:
    • ≥ 1200px
    • 576px – 1200px
    • < 576px

Notes

  • Ideally CSS can change media queries to match diff markup per subsite.
  • But there is not a feasible CSS way to do this.
  • And the effort for a way it can be done (nesting rules) is too great.
  • So great an effort I might as well update Portal & Docs markup.

Use `navbar-expand-lg` (for now) to match Portal & Docs.

Notes:
- Ideally CSS can change media queries to match diff markup per subsite.
- But there is NOT feasible CSS way to do this.
- And the effort for a way it can be done (nesting rules) is too great.
- So great an effort I might as well update Portal+Docs markup.
@wesleyboar wesleyboar self-assigned this Jun 4, 2021
@wesleyboar wesleyboar linked an issue Jun 4, 2021 that may be closed by this pull request
@wesleyboar wesleyboar merged commit 135ae8d into task/GH-101-header-redesign Jun 4, 2021
@wesleyboar wesleyboar deleted the hotfix/GH-101-header-redesign--media-queries branch June 4, 2021 06:47
@wesleyboar wesleyboar mentioned this pull request Jun 4, 2021
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Header Redesign → FP-1458
1 participant