fix(css): theme has-dark-logo aka light header #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleyboar
changed the base branch from
main
to
task/get-core-styles-beyond-0.11.0
…e-has-dark-logo-aka-light-header
wesleyboar
changed the title
wesleyboar
changed the title
This branch accidentally had task/demdata-css-from-tup checked out.
…e-has-dark-logo-aka-light-header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Allow loading
has-dark-logoheader's from Core-Styles.Related
Changes
header.theme-has-dark-logo.cssTesting
UI
demdata-cms(TACC/Core-CMS-Resources#173)Notes
Known Issues
Search bar is still dark.
The template to overwrite,
nav_search.raw.html, can not be overwritten from a https://github.com/TACC/Core-CMS-Resources site (without Bugfix/fp 1652 template load order #492).One way to solve is to migrate https://github.com/TACC/Core-CMS-Resources/tree/main/demdata-cms to https://github.com/TACC/Core-CMS-Custom (a setup in which sites can overwrite templates).
This problem is not an immediate concern for demdata-cms, because the design does not show it having a search bar.