Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CMD-143 deprecate most CMS document style class names #355

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Jul 24, 2024

Overview

Deprecate these classes:

  • s-document
  • s-inline-dl
  • u-nested-text-content

Clients should remove them and use only .s-guide-doc wrapper.

Update this class to take over:

  • s-guide-doc

Added styles from deprecated classes but used markup in selectors.

Related

Changes

  • commented "(DEPRECATED)" on some files
  • deleted comments to consider using some files
  • migrated deprecated styles (that are not already in s-guide-doc)

Testing & UI

Skipped.

I combined styles that are still used into `s-guide-doc.css`.

I deprecated the remaining classes.

Clients will have redundant stlyes on guide docs until they stop using:
- s-document
- s-inline-dl
- u-nested-text-content

The following class is still used:
- s-guide-doc
@github-actions github-actions bot added the feature A new feature or replacement of existing feature label Jul 24, 2024
@wesleyboar wesleyboar added the minor A feature in backward-compatible manner label Jul 24, 2024
@wesleyboar wesleyboar merged commit c9795f5 into main Jul 24, 2024
5 checks passed
@wesleyboar wesleyboar deleted the feat/CMD-143-consolidate-guide-doc-styles branch July 24, 2024 22:13
wesleyboar added a commit that referenced this pull request Jul 24, 2024
wesleyboar added a commit that referenced this pull request Jul 24, 2024
* chore: v2.27.1

* build: v2.27.1 #355 (CMD-43)

* build: v2.27.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature or replacement of existing feature minor A feature in backward-compatible manner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant