Issue 502: Angularjs $location.search is not safe to use when passing '#'. #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… '#'. This addresses the problem by replacing the `#` (U+0023) character with `%23` for relevant situations (properties in the search). This needs to be tested for regressions, specifically checking for data in facets and filters that have the `#` (U+0023) character.
jeremythuff
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the solution created while investigating the spike #492.
This addresses the problem by replacing the
#(U+0023) character with%23for relevant situations (properties in the search).This needs to be tested for regressions, specifically checking for data in facets and filters that have the
#(U+0023) character.Fixes #502
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
mvn clean test.Checklist: