Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 557 google analytics #558

Merged
merged 21 commits into from
Sep 28, 2023
Merged

Issue 557 google analytics #558

merged 21 commits into from
Sep 28, 2023

Conversation

qtamu
Copy link
Contributor

@qtamu qtamu commented Sep 13, 2023

Deleted old commands from the Dockerfile and unused script from the entrypoin.sh file. Got rid of the txt file because they were no long needed with this new implementation. Added the tags using Thymeleaf.

@qtamu qtamu requested a review from jeremythuff September 13, 2023 21:19
@qtamu qtamu self-assigned this Sep 13, 2023
Copy link
Contributor Author

@qtamu qtamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and added the configuration property directly to the controller and removed it from the service. c3f00ac

@qtamu qtamu requested a review from kaladay September 26, 2023 18:26
Copy link
Contributor Author

@qtamu qtamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made changes

@qtamu qtamu linked an issue Sep 28, 2023 that may be closed by this pull request
Copy link
Contributor

@kaladay kaladay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add googleTag: settings to the test application.yml at:

src/test/resources/application.yml

@github-actions
Copy link

Coverage Status

coverage: 45.876% (+0.01%) from 45.864% when pulling 75bf853 on issue-557-google-analytics into 4e93c95 on main.

@kaladay kaladay merged commit 477af8a into main Sep 28, 2023
@qtamu qtamu deleted the issue-557-google-analytics branch September 28, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants