-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 557 google analytics #558
Conversation
Line added to the bottom
… google_scripts
src/main/java/edu/tamu/sage/service/SimpleProcessorService.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went ahead and added the configuration property directly to the controller and removed it from the service. c3f00ac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add googleTag:
settings to the test application.yml at:
src/test/resources/application.yml
Deleted old commands from the Dockerfile and unused script from the entrypoin.sh file. Got rid of the txt file because they were no long needed with this new implementation. Added the tags using Thymeleaf.