Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More descriptive unfold error - fix 2043616 #117

Merged
merged 3 commits into from
Nov 23, 2023
Merged

More descriptive unfold error - fix 2043616 #117

merged 3 commits into from
Nov 23, 2023

Conversation

mtygesen
Copy link
Contributor

Fixes: https://bugs.launchpad.net/tapaal/+bug/2043616

  • Added FormatException being thrown from isNetDrawable() when the size of the net exceeds maxNetSize.

@srba srba self-requested a review November 23, 2023 19:37
srba
srba requested changes Nov 23, 2023
View reviewed changes
Copy link
Member

@srba srba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The loading of big PNML net now returns the message, however, if you verify CPN and ask for a trace, then loading the net to the simulator does not catch and properly handle the raised exception

@srba srba self-requested a review November 23, 2023 20:49
srba
srba approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@srba srba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the problems.

@srba srba merged commit 5027ce4 into TAPAAL:main Nov 23, 2023
1 check passed
@mtygesen mtygesen deleted the verifypn-unfold-fix-2043616 branch November 26, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srba srba srba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtygesen @srba