Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color bindings to simulation #134

Merged
merged 4 commits into from
Feb 9, 2024
Merged

Color bindings to simulation #134

merged 4 commits into from
Feb 9, 2024

Conversation

mtygesen
Copy link
Contributor

@mtygesen mtygesen commented Feb 1, 2024

Added tooltips showing transitions color binds

@srba srba self-requested a review February 5, 2024 12:40
Copy link
Member

@srba srba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

referendum-timed-colored example cannot be unfolded (pressing M gives an error)

@srba
Copy link
Member

srba commented Feb 5, 2024

Also, if there are more than two variables in the binding, the GUI shows only the last one

@srba
Copy link
Member

srba commented Feb 6, 2024

Please, merge also main to this branch.

@srba
Copy link
Member

srba commented Feb 7, 2024

If I press only "M" in the referendum-timed-colored (enter the simulator without running a query), the bindings are not shown. This is an issue in verifydtapn and verifytapn and I will fix it in the engines.

@srba
Copy link
Member

srba commented Feb 7, 2024

Finally, for some reason the GUI seems to send to the engine variable "x" as "varx" - i.e. it adds the "var" prefix, which is confusing ... could you try to find where this "var" is added and try not to do it (just pass only variable names) to see if this breaks anything?

Copy link
Member

@srba srba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works all fine except for the fact that it shows variable id's instead of names - will be fixed in another branch.

@srba srba merged commit 205a745 into TAPAAL:main Feb 9, 2024
1 check passed
@mtygesen mtygesen deleted the color-bindings branch February 11, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants