Fix stubborn reduction bug involving inhibitor arcs #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srba
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an ordering-dependant bug in the stubborn set reductions involving presets consisting of mixed arcs and inhibitor arcs. The issue arises from a simple
inhibflag which should only be updated whenever the correspondingcandindex is updated.Example of wrong behavior:
Consider the following Petri net and query
EF P0 = 0(stub_inhib_test.zip)../verifypn-linux64 stub_inhib_test.pnml stub_inhib_test.xml -x 1 -q 0 -r 0results in "NOT satisfied",./verifypn-linux64 stub_inhib_test.pnml stub_inhib_test.xml -x 1 -q 0 -r 0 -presults in "satisfied".The query should be satisfied with trace: T3 T0.