Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title to movie links in wiki #1750

Merged
merged 4 commits into from
Jan 24, 2024
Merged

Add title to movie links in wiki #1750

merged 4 commits into from
Jan 24, 2024

Conversation

nattthebear
Copy link
Collaborator

@nattthebear nattthebear commented Jan 23, 2024

This matches behavior in the old site, where a ##M / ##S / ##G link with link text provided would still get the standard text as a title.

[1M]             ->       <a href=/1M>[1] Some Really Awesome Movie</a>
[1M|foo]         ->       <a href=/1M title="[1] Some Really Awesome Movie">foo</a>

The implementation logic be reasonably straightforward; it just has to process substitutions and replacements in a specific order to get the fallback behavior we need.

fixes #1349

@vadosnaprimer
Copy link
Collaborator

I checked and it's ready now.

@nattthebear nattthebear changed the title [WIP] Add title to movie links in wiki Add title to movie links in wiki Jan 24, 2024
@nattthebear nattthebear marked this pull request as ready for review January 24, 2024 18:09
@adelikat adelikat merged commit 1c8034d into main Jan 24, 2024
1 check passed
@adelikat adelikat deleted the movie-displaynames branch January 24, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wiki: Show tooltip on internal urls
3 participants