Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set $(EnableConfigurationBindingGenerator) (reduces reflection) #1968

Merged
merged 1 commit into from
Sep 28, 2024
Merged

Set $(EnableConfigurationBindingGenerator) (reduces reflection) #1968

merged 1 commit into from
Sep 28, 2024

Conversation

YoshiRulz
Copy link
Collaborator

No description provided.

@adelikat
Copy link
Collaborator

adelikat commented Sep 4, 2024

Does this really reduce reflection? I thought it was necessary if you build your own source generators

@YoshiRulz
Copy link
Collaborator Author

Well I can confirm it generates something. The docs say that it uses reflection when the Source Generator isn't enabled.

@adelikat adelikat self-requested a review September 28, 2024 14:52
@adelikat adelikat merged commit 47aa07f into TASVideos:main Sep 28, 2024
1 check passed
@YoshiRulz YoshiRulz deleted the config-binding-srcgen branch September 28, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adelikat adelikat adelikat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YoshiRulz @adelikat