Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable extra sanity checks on service provider #1969

Closed
wants to merge 1 commit into from

Conversation

YoshiRulz
Copy link
Collaborator

My understanding is that these are checks for services initialised out of order, and out-of-the-box those would silently fail. In any case the checks currently pass on my machine.

@Masterjun3
Copy link
Collaborator

According to docs, these are by default already true on Dev builds, and false on other builds.

@adelikat
Copy link
Collaborator

So we already get this level of checking on dev builds, this is just for production builds. I'm not sure we need these extra checks at this point.

@adelikat adelikat closed this Sep 28, 2024
@YoshiRulz YoshiRulz deleted the service-provider-checks branch September 28, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants