Misc. invisible changes to links and metadata #2002
Conversation
The way this is implemented is that *only external links* are marked as UGC, not links to pubs/wiki/other pages within the site. By "all links in forum markup" I mean exactly that--every link which appears in everyone's posts in every thread, and all signatures, and all PMs. That simplicity meant it was a 1-line change, compared to all the work it took to distinguish wiki pages.
includes the beginnings of some HTML5 semantic markup, which I intend to expand on later paragraph linking to `/TextFormattingRules` must be a system page, and same with submission instructions, because I couldn't find them to add `rel="help"`
| @@ -12,7 +12,7 @@ public static partial class Builtins | |||
| /// <summary> | |||
| /// Turns text inside [square brackets] into the appropriate thing, usually module or link. Does not handle [if:]. | |||
| /// </summary> | |||
| public static IEnumerable<INode> MakeBracketed(int charStart, int charEnd, string text) | |||
| public static IEnumerable<INode> MakeBracketed(int charStart, int charEnd, bool isUGC, string text) | |||
There was a problem hiding this comment.
User-generated content https://developers.google.com/search/docs/crawling-indexing/qualify-outbound-links#ugc
There was a problem hiding this comment.
I'm struggling to understand the code here. How does it determine which Wiki pages are UGC and which aren't? Shouldn't we consider ALL wiki pages as UGC? It's a wiki.
There was a problem hiding this comment.
For wiki-lang content, I've done IsUGC => wikiPage.IsHomePageOrSubmissionNotes();, under the assumption that those who have been granted wiki edit perms are trusted.
There was a problem hiding this comment.
All this logic just to put a create common license only on submission and homepage content? All the wiki pages have a notice that they are creative commons, on the save button.
I don't mind the header. But I do mind that it isn't consistent across wiki pages. And I don't think it should be the parsers responsibility to make these distinctions or worry about the license
| @@ -12,7 +12,7 @@ public static partial class Builtins | |||
| /// <summary> | |||
| /// Turns text inside [square brackets] into the appropriate thing, usually module or link. Does not handle [if:]. | |||
| /// </summary> | |||
| public static IEnumerable<INode> MakeBracketed(int charStart, int charEnd, string text) | |||
| public static IEnumerable<INode> MakeBracketed(int charStart, int charEnd, bool isUGC, string text) | |||
There was a problem hiding this comment.
All this logic just to put a create common license only on submission and homepage content? All the wiki pages have a notice that they are creative commons, on the save button.
I don't mind the header. But I do mind that it isn't consistent across wiki pages. And I don't think it should be the parsers responsibility to make these distinctions or worry about the license
This reverts commit a3b9899.
|
Closing for comments above |
Broadly SEO-related, though I won't claim this kind of change will improve, or have any impact on, the site's ranking in Google results.
edit: I get the feeling this is more likely to get merged if it's split into multiple PRs, but I have several open already, so I'll do that later.