Remove StringLength attributes from Entities #2046
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the string length attributes and makes an empty migration, only changing the model snapshot.
We use postgres columns
text
(or rathercitext
) which doesn't have string limits.And we don't need a limited string type, as per the docs:
I haven't found any uses of direct Entity types for form binding (this would cause client and server validation to be removed by this PR). We basically always use a separate model for that.
Those models now technically don't need the StringLength either, but even though we can store any lenghts, we still don't need to allow users to spam us with massive strings.