chore: don't start mysql for every test (#3439)

The provisioner should start it if it is needed.

backend/provisioner/dev_provisioner.go

@@ -3,6 +3,7 @@ package provisioner
 import (
 	"context"
 	"fmt"
+	"time"
 
 	"github.com/XSAM/otelsql"
 	_ "github.com/go-sql-driver/mysql"
@@ -38,39 +39,61 @@ func provisionMysql(mysqlPort int) InMemResourceProvisionerFn {
 		if err != nil {
 			return nil, fmt.Errorf("failed to wait for mysql to be ready: %w", err)
 		}
-		conn, err := otelsql.Open("mysql", mysqlDSN)
-		if err != nil {
-			return nil, fmt.Errorf("failed to connect to mysql: %w", err)
-		}
-		defer conn.Close()
-
-		res, err := conn.Query("SELECT SCHEMA_NAME FROM INFORMATION_SCHEMA.SCHEMATA WHERE SCHEMA_NAME = ?", dbName)
-		if err != nil {
-			return nil, fmt.Errorf("failed to query database: %w", err)
-		}
-		defer res.Close()
-		if res.Next() {
-			_, err = conn.ExecContext(ctx, "DROP DATABASE "+dbName)
-			if err != nil {
-				return nil, fmt.Errorf("failed to drop database: %w", err)
+		timeout := time.After(10 * time.Second)
+		retry := time.NewTicker(100 * time.Millisecond)
+		defer retry.Stop()
+		for {
+			select {
+			case <-timeout:
+				return nil, fmt.Errorf("failed to query database: %w", err)
+			case <-retry.C:
+				var ret *provisioner.Resource
+				ret, err = establishMySQLDB(ctx, rc, mysqlDSN, dbName, mysql, mysqlPort)
+				if err != nil {
+					logger.Debugf("failed to establish mysql database: %s", err.Error())
+					continue
+				}
+				return ret, nil
 			}
+
 		}
 
-		_, err = conn.ExecContext(ctx, "CREATE DATABASE "+dbName)
+	}
+}
+
+func establishMySQLDB(ctx context.Context, rc *provisioner.ResourceContext, mysqlDSN string, dbName string, mysql *provisioner.Resource_Mysql, mysqlPort int) (*provisioner.Resource, error) {
+	conn, err := otelsql.Open("mysql", mysqlDSN)
+	if err != nil {
+		return nil, fmt.Errorf("failed to connect to mysql: %w", err)
+	}
+	defer conn.Close()
+
+	res, err := conn.Query("SELECT SCHEMA_NAME FROM INFORMATION_SCHEMA.SCHEMATA WHERE SCHEMA_NAME = ?", dbName)
+	if err != nil {
+		return nil, fmt.Errorf("failed to query database: %w", err)
+	}
+	defer res.Close()
+	if res.Next() {
+		_, err = conn.ExecContext(ctx, "DROP DATABASE "+dbName)
 		if err != nil {
-			return nil, fmt.Errorf("failed to create database: %w", err)
+			return nil, fmt.Errorf("failed to drop database: %w", err)
 		}
+	}
 
-		if mysql.Mysql == nil {
-			mysql.Mysql = &provisioner.MysqlResource{}
-		}
-		dsn := dsn.MySQLDSN(dbName, dsn.Port(mysqlPort))
-		mysql.Mysql.Output = &provisioner.MysqlResource_MysqlResourceOutput{
-			WriteDsn: dsn,
-			ReadDsn:  dsn,
-		}
-		return rc.Resource, nil
+	_, err = conn.ExecContext(ctx, "CREATE DATABASE "+dbName)
+	if err != nil {
+		return nil, fmt.Errorf("failed to create database: %w", err)
+	}
+
+	if mysql.Mysql == nil {
+		mysql.Mysql = &provisioner.MysqlResource{}
+	}
+	dsn := dsn.MySQLDSN(dbName, dsn.Port(mysqlPort))
+	mysql.Mysql.Output = &provisioner.MysqlResource_MysqlResourceOutput{
+		WriteDsn: dsn,
+		ReadDsn:  dsn,
 	}
+	return rc.Resource, nil
 }
 
 func provisionPostgres(postgresPort int) func(ctx context.Context, rc *provisioner.ResourceContext, module string, id string) (*provisioner.Resource, error) {

docker-compose.yml

@@ -19,6 +19,8 @@ services:
       retries: 60
       start_period: 80s
   mysql:
+    profiles:
+      - mysql
     image: mysql:8.4.3
     environment:
       MYSQL_ROOT_PASSWORD: secret

jvm-runtime/ftl-runtime/common/runtime/src/main/java/xyz/block/ftl/runtime/FTLController.java

@@ -88,10 +88,8 @@ public byte[] getConfig(String secretName) {
     }
 
     public Datasource getDatasource(String name) {
-        log.errorf("GET DATASOURCE");
         List<ModuleContextResponse.DSN> databasesList = getModuleContext().getDatabasesList();
         for (var i : databasesList) {
-            log.errorf("DSN %s %s", i.getName(), i.getDsn());
             if (i.getName().equals(name)) {
                 return Datasource.fromDSN(i.getDsn(), i.getType());
             }