Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: language plugin logs #3373

Merged
merged 1 commit into from
Nov 12, 2024
Merged

fix: language plugin logs #3373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions go-runtime/compile/build.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@ func Build(ctx context.Context, projectRootDir, stubsRoot string, config modulec

wg.Go(func() error {
if !importsChanged {
log.FromContext(ctx).Debugf("skipped go mod tidy (module dir)\n")
log.FromContext(ctx).Debugf("skipped go mod tidy (module dir)")
return nil
}
if err := exec.Command(wgctx, log.Debug, config.Dir, "go", "mod", "tidy").RunStderrError(wgctx); err != nil {
Expand All @@ -437,7 +437,7 @@ func Build(ctx context.Context, projectRootDir, stubsRoot string, config modulec
mainDir := filepath.Join(buildDir, "go", "main")
wg.Go(func() error {
if !mainModuleCtxChanged {
log.FromContext(ctx).Debugf("skipped go mod tidy (build dir)\n")
log.FromContext(ctx).Debugf("skipped go mod tidy (build dir)")
return nil
}
if err := exec.Command(wgctx, log.Debug, mainDir, "go", "mod", "tidy").RunStderrError(wgctx); err != nil {
Expand Down
2 changes: 1 addition & 1 deletion internal/buildengine/languageplugin/plugin_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ func (p *pluginClientImpl) start(ctx context.Context, dir, language, name string
dir,
cmdPath,
langconnect.NewLanguageServiceClient,
plugin.WithEnvars("FTL_Name="+name),
plugin.WithEnvars("FTL_NAME="+name),
)
if err != nil {
return fmt.Errorf("failed to spawn plugin for %s: %w", name, err)
Expand Down
Loading