feat: hot reload #3392
Merged
feat: hot reload #3392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartwdouglas
added
the
skip-proto-breaking
stuartwdouglas
requested review from
tomdaffurn and
wesbillman
and removed request for
a team
stuartwdouglas
force-pushed
the
stuartwdouglas/hot-reload-pr
branch
from
617f4cb
to
66a525a
Compare
stuartwdouglas
force-pushed
the
stuartwdouglas/hot-reload-pr
branch
5 times, most recently
from
ec7198d
to
401db79
Compare
matt2e
reviewed
Nov 15, 2024
| @@ -167,6 +172,9 @@ func (s *Service) SyncStubReferences(ctx context.Context, req *connect.Request[l | |||
| // rebuild must include the latest build context id provided by the request or subsequent BuildContextUpdated | |||
| // calls. | |||
| func (s *Service) Build(ctx context.Context, req *connect.Request[langpb.BuildRequest], stream *connect.ServerStream[langpb.BuildEvent]) error { | |||
| if req.Msg.RebuildAutomatically { | |||
| return s.handleDevModeRequest(ctx, req, stream) | |||
| } | |||
| events := make(chan updateEvent, 32) | |||
There was a problem hiding this comment.
the rest of this function can be gutted I think as it has a lot of logic for receiving new build contexts and watching for file changes, which only happens if req.Msg.RebuildAutomatically is true.
Oh wait I'm actually not sure how you are reacting to build context changes?
There was a problem hiding this comment.
I am not handling that properly I think, I need to move some of this logic into the hot reload path.
There was a problem hiding this comment.
I think I am handling this properly now
stuartwdouglas
force-pushed
the
stuartwdouglas/hot-reload-pr
branch
5 times, most recently
from
9296515
to
21a60c4
Compare
|
I need to add some tests around this, but I think they need a different approach to the existing language tests, as most of the logic is handled by Quarkus itself. |
stuartwdouglas
force-pushed
the
stuartwdouglas/hot-reload-pr
branch
4 times, most recently
from
1089c72
to
741d550
Compare
stuartwdouglas
force-pushed
the
stuartwdouglas/hot-reload-pr
branch
11 times, most recently
from
615f692
to
8be052d
Compare
JVM languages can now used how reload for instant feedback
stuartwdouglas
force-pushed
the
stuartwdouglas/hot-reload-pr
branch
from
8be052d
to
28b08aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JVM languages can now used how reload for instant feedback