feat: cron service #3399
Merged
feat: cron service #3399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecthomas
force-pushed
the
aat/cron-service
branch
from
ba08a20 to
777fb9e
Compare
Functional but not not completely wired up. Tests pass, metrics aren't hooked up, no main service binary.
alecthomas
force-pushed
the
aat/cron-service
branch
from
777fb9e to
3a1a435
Compare
matt2e
reviewed
Nov 15, 2024
| orderQueue(cronQueue) | ||
|
|
||
| if err := callCronJob(ctx, verbClient, job); err != nil { | ||
| logger.Errorf(err, "Failed to execute cron job") |
There was a problem hiding this comment.
Looks like we're dropping support for retry policies on cron? We should probably make that a validation check to ensure no retry directives on cron job verbs if so.
There was a problem hiding this comment.
Or maybe just a ticket to add retry logic back in
There was a problem hiding this comment.
It seems likely we'll be moving retries to Istio.
matt2e
approved these changes
Nov 15, 2024
|
Looks sweet and relatively simple 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functional but not not completely wired up. Tests pass, metrics aren't hooked up, no main service binary.