fix: switch PullSchemaResponse.deployment_key to optional #3533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecthomas
commented
Nov 26, 2024
| deploymentKey string | ||
| uri url.URL | ||
| // Set to None under mysterious circumstances... | ||
| deploymentKey optional.Option[model.DeploymentKey] |
There was a problem hiding this comment.
@stuartwdouglas I couldn't quite grok why this was being set to ""
alecthomas
added
the
skip-proto-breaking
This reflects the fact that builtin modules will not have an associated deployment key. Also use strongly typed model.DeploymentKey where appropriate.
alecthomas
force-pushed
the
aat/optional-deployment-key
branch
from
ad07956
to
e9ddb21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reflects the fact that builtin modules will not have an associated deployment key.
Also use strongly typed model.DeploymentKey where appropriate.