Prefix JSON serialized data members with json_serialized_* & remove unnecessary type definitions #63
Conversation
KendallWeihe
requested review from
nitro-neal,
kirahsapong,
shamilovtim,
diehuxx,
decentralgabe and
frankhinek
as code owners
KendallWeihe
changed the title
| } | ||
|
|
||
| data class InputDescriptor( |
There was a problem hiding this comment.
This is in mainline web5-rs now, so idk when the time will come when we take this out and use web5-rs
There was a problem hiding this comment.
Yeah we need to make that jump sooner rather than later, but I'm not prepared to full-commit to a hosting solution. @nitro-neal what do you think about a temporary measure like throwing something up to jitpack, with recognition it isn't our longterm hosting solution?
| } | ||
| Some(s) => s | ||
| .iter() | ||
| .find(|s| s.r#type == *"PFI") |
There was a problem hiding this comment.
should probably make PFI a parameter,
an optional type parameter, if none specified it will return first or something
There was a problem hiding this comment.
well this is a function specific to tbdex, not a generalized function for retrieving service endpoints from did's
I'm open to adding something to web5 which is more generalizable, but something for a later date
At the UniFFI layer, types which require JSON serialization are serialized in-full, so that rather than duplicating type definitions 3 times, we only need to do so 2 times