Fix crash when using String::move on empty string (espressif#10938)

Fixes: espressif#10938
TD-er · Feb 6, 2025 · d33b221 · d33b221
1 parent 6fcaf69
commit d33b221
Showing 1 changed file with 6 additions and 10 deletions.
diff --git a/cores/esp32/WString.cpp b/cores/esp32/WString.cpp
@@ -238,16 +238,15 @@ String &String::copy(const char *cstr, unsigned int length) {
 #ifdef __GXX_EXPERIMENTAL_CXX0X__
 void String::move(String &rhs) {
   if (buffer()) {
-    if (capacity() >= rhs.len()) {
+    if (capacity() >= rhs.len() && rhs.len() && rhs.buffer()) {
       memmove(wbuffer(), rhs.buffer(), rhs.length() + 1);
       setLen(rhs.len());
       rhs.invalidate();
       return;
-    } else {
-      if (!isSSO()) {
-        free(wbuffer());
-        setBuffer(nullptr);
-      }
+    }
+    if (!isSSO()) {
+      free(wbuffer());
+      setBuffer(nullptr);
     }
   }
   if (rhs.isSSO()) {
@@ -259,10 +258,7 @@ void String::move(String &rhs) {
   }
   setCapacity(rhs.capacity());
   setLen(rhs.len());
-  rhs.setSSO(false);
-  rhs.setCapacity(0);
-  rhs.setBuffer(nullptr);
-  rhs.setLen(0);
+  rhs.init();
 }
 #endif