Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Fix #708 #1025
base: main
Are you sure you want to change the base?
[WIP] Fix #708 #1025
Changes from all commits
aeb8524
7439217
82bfeb1
5cd3a35
033bc3b
ab280e5
c51b7a3
8464b70
f548907
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels strange. You declare
all_stumpy_functions
as aset()
above and then youupdate
it and then you convert it into a list all within a for-loop.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing that I forgot to notice is that the nested dictionary
all_functions
has unique values for all_functions['file_name']['func_names"]. So, I can just uselist
.Does that address your concern?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not entirely clear what the goal is here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Every time I look at it... I feel like the nested dictionary makes it hard to read. I need to re-design it.
My goal was to create a comprehensive list that contains all the functions that are defined in
./stumpy/
, and then use it to ignore any callee that is NOT in that comprehensive list. For instance,range
can be a callee of a function. However, I do not want to keep it. I want to only have the callers/ callees that are defined in stumpy.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seanlaw
Previously, I wanted to follow the chain of callees. Now, as you may notice here, I am trying to get list of callers for each function. We can start with those functions that are njit-decorated and have fastmath flag, and then follow the chain of callers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Whatever you think might work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to confess here... I think there is a code smell here because of nested for-loop. Although I tried a couple of times, I think I still need to work on this part as it seems to be complicated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Note to self]
One thing I need to consider here is how things will work if a callee is assigned to a variable before being used. For instance:
stumpy/stumpy/core.py
Line 2569 in b7b355c