Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12946] Initialise Entities for Course Structure #12948

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

domlimm
Copy link
Contributor

@domlimm domlimm commented Mar 27, 2024

Part of #12946.

Outline of Solution
Initialise entities needed for Course Structure.

@domlimm domlimm requested review from weiquu and kevin9foong March 27, 2024 12:54
Copy link
Member

@kevin9foong kevin9foong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@weiquu weiquu added the s.FinalReview The PR is ready for final review label Mar 27, 2024
Copy link
Contributor

@weiquu weiquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@domlimm just some small changes

@domlimm domlimm changed the title [#12946] Initialise DDL for Course Structure [#12946] Initialise Entities for Course Structure Mar 30, 2024
- Add courseStructures to Course
- Remove teamToStudentMaps from Team as superseded by Students
@domlimm domlimm requested a review from weiquu March 30, 2024 04:36
Copy link
Contributor

@weiquu weiquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weiquu weiquu merged commit d372790 into TEAMMATES:multiple-course-structures Apr 4, 2024
1 of 10 checks passed
domlimm added a commit to domlimm/teammates that referenced this pull request Apr 15, 2024
…#12948)

* Initialise DDL for Course Structure

* Resolve PR comments
- Add courseStructures to Course
- Remove teamToStudentMaps from Team as superseded by Students

---------

Co-authored-by: Wei Qing <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s.FinalReview The PR is ready for final review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants