-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#13122] Added cancel button #13132
[#13122] Added cancel button #13132
Conversation
Hi @CameronMooreGit, thank you for your interest in contributing to TEAMMATES!
Please address the above before we proceed to review your PR. |
@CameronMooreGit do fix the failing tests. You can visit our documentation to find out more about how to update our snapshot tests. In addition, please don't use plain CSS styling in the components - you can use Bootstrap classes instead. This helps to keep our styling consistent |
Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢 |
hi @CameronMooreGit do update the failing tests, you most likely would need to update the snapshots. Also agree with the comment above, do try to use Bootstrap classes instead of raw CSS. |
Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢 |
Folks, This PR seems to be stalling (no activities for the past 9 days). 🐌 😢 |
Folks, This PR seems to be stalling (no activities for the past 8 days). 🐌 😢 |
hi @CameronMooreGit closing due to inactivity, please reopen when you are ready! |
Fixes #13122 Account Request Form: Adding Cancel button
Outline of Solution
The solution to this problem involved adding a hyperlink that redirects the user from the instructor registration page to the home page. The hyperlink has the appearance of a button by using the btn class. I added a style to the submit button to include a margin-right 15px, making a clean-looking gap between the two buttons appear. See below for visual changes: