Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added noWhitespaceValidator #13168

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mishalsheza
Copy link

[#12679] Copying feedback session: Name for copied session should not be whitespace (#12679)

Fixes #12679
Outline of Solution

Added a custom validator to the email field to ensure it does not contain only whitespace.
Custom Validator (noWhitespaceValidator): This validator checks if the input contains only whitespace and returns an error if it does.

Form Group Initialization: Updated the form group initialization in both ngOnInit and resetFormGroups to include the custom validator for the email field.

Error Handling: Ensure that the error messages are handled appropriately in the UI if the validator detects a whitespace-only value.

This approach ensures that any whitespace-only values for the email field are effectively handled both on the client side and before submission.

Copy link

Hi @mishalsheza, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Title must start with the issue number the PR is fixing in square brackets, e.g. [#<issue-number>]

Please address the above before we proceed to review your PR.

@mishalsheza mishalsheza reopened this Aug 10, 2024
Copy link

Hi @mishalsheza, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Title must start with the issue number the PR is fixing in square brackets, e.g. [#<issue-number>]

Please address the above before we proceed to review your PR.

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

2 similar comments
@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copying feedback session: Name for copied session should not be whitespace
2 participants