Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12679] Solved the problem of space detection, and can prompt an error for illegal space input #13178

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

[#12679] Solved the problem of space detection, and can prompt an error for illegal space input #13178

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2d0ae16
solved #12679
u7861723 Oct 11, 2024
9349569
Merge pull request #1 from u7861723/Tianxiang
Yokyeee1114 Oct 11, 2024
91389f1
change single quote
u7861723 Oct 25, 2024
0db073c
delete Unnecessary escape character: \"
u7861723 Oct 25, 2024
6167e76
delete errorMessage
u7861723 Oct 25, 2024
5448823
delete blank lines
u7861723 Oct 25, 2024
18785ae
add judgment this.newFeedbackSessionName.length > this.FEEDBACK_SESSI…
u7861723 Oct 25, 2024
3c42630
change file
u7861723 Oct 25, 2024
ea469ac
add trailing comma
u7861723 Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/web/app/components/copy-session-modal/copy-session-modal.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { Component, Input } from '@angular/core';
import { NgbActiveModal } from '@ng-bootstrap/ng-bootstrap';
import { StatusMessageService } from '../../../services/status-message.service';
import { Course } from '../../../types/api-output';
import { FEEDBACK_SESSION_NAME_MAX_LENGTH } from '../../../types/field-validator';

Expand All @@ -25,12 +26,23 @@ export class CopySessionModalComponent {
newFeedbackSessionName: string = '';
copyToCourseSet: Set<string> = new Set<string>();

constructor(public activeModal: NgbActiveModal) {}
constructor(public activeModal: NgbActiveModal, private statusMessageService: StatusMessageService) {}

/**
* Fires the copy event.
*/
copy(): void {
if (this.newFeedbackSessionName.trim().length === 0) {
this.statusMessageService.showErrorToast('The field "Name for copied session" should not be whitespace.');
return;
}
if (this.newFeedbackSessionName.length > this.FEEDBACK_SESSION_NAME_MAX_LENGTH) {
this.statusMessageService.showErrorToast(
`The field "Name for copied session" should less than ${this.FEEDBACK_SESSION_NAME_MAX_LENGTH}.`,
);
return;
}

this.activeModal.close({
newFeedbackSessionName: this.newFeedbackSessionName,
sessionToCopyCourseId: this.sessionToCopyCourseId,
Expand Down
Loading