Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #657 #682

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

Fixes #657 #682

wants to merge 2 commits into from

Conversation

joeytakeda
Copy link
Contributor

Adds another rule to odd.css to ensure colon and space

Adds another rule to odd.css to ensure colon and space
@joeytakeda joeytakeda linked an issue May 6, 2024 that may be closed by this pull request
@ebeshero ebeshero requested review from HelenaSabel and sydb and removed request for HelenaSabel July 6, 2024 20:29
@ebeshero
Copy link
Member

ebeshero commented Jul 7, 2024

@sydb @martinascholger @HelenaSabel I think we just lost track of this work that @joeytakeda did in May to improve the output CSS of generated ODDs. I just updated the branch and the tests are passing. (I'm not suggesting we merge it for the imminent release, but we may want to continue working on CSS for custom ODD-generated HTML on this branch, and merge for the next release?)

@HelenaSabel
Copy link
Member

HelenaSabel commented Jul 7, 2024

@ebeshero: I will be partial to merging the current work as it is after the release (if @joeytakeda agrees). In principle, the current generation of ODD documentation will be superseded relatively soon so I wonder if it isn’t better to work on issues with higher priority.

Copy link
Member

@sydb sydb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not investigate why, but with this PR there is not just a “: ” after the classname before the list of attributes, there is a “ : ”. (That is, space-colon-space instead of just colon-space.)

@joeytakeda
Copy link
Contributor Author

I did not investigate why, but with this PR there is not just a “: ” after the classname before the list of attributes, there is a “ : ”. (That is, space-colon-space instead of just colon-space.)

I'm not sure what you were seeing here, @sydb — in looking at the changes, I only see colon+space not space+colon+space.

@sydb
Copy link
Member

sydb commented Nov 25, 2024

Well, I cannot at the moment reproduce the problem I was seeing before, thus approving. (Not sure why this is a draft PR — as far as I am concerned it can be merged.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

styling of new attr lists
4 participants