-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #657 #682
base: dev
Are you sure you want to change the base?
Fixes #657 #682
Conversation
@sydb @martinascholger @HelenaSabel I think we just lost track of this work that @joeytakeda did in May to improve the output CSS of generated ODDs. I just updated the branch and the tests are passing. (I'm not suggesting we merge it for the imminent release, but we may want to continue working on CSS for custom ODD-generated HTML on this branch, and merge for the next release?) |
@ebeshero: I will be partial to merging the current work as it is after the release (if @joeytakeda agrees). In principle, the current generation of ODD documentation will be superseded relatively soon so I wonder if it isn’t better to work on issues with higher priority. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not investigate why, but with this PR there is not just a “: ” after the classname before the list of attributes, there is a “ : ”. (That is, space-colon-space instead of just colon-space.)
I'm not sure what you were seeing here, @sydb — in looking at the changes, I only see colon+space not space+colon+space. |
Well, I cannot at the moment reproduce the problem I was seeing before, thus approving. (Not sure why this is a draft PR — as far as I am concerned it can be merged.) |
Adds another rule to odd.css to ensure colon and space