Minor code cleanup

See merge request main/Sumatra!1782

sumatra-commit: 85a86ce684747b15b3802ba38a9557d8b40241bd

modules/common-gui/src/main/java/edu/tigers/sumatra/AMainPresenter.java

@@ -114,13 +114,6 @@ public void onDeleteLayout()
 	}
 
 
-	@Override
-	public void onRefreshLayoutItems()
-	{
-		refreshLayoutItems();
-	}
-
-
 	@Override
 	public void onLoadLayout(final String filename)
 	{
@@ -144,7 +137,7 @@ public void onLoadLayout(final String filename)
 	public void onExit()
 	{
 		GlobalShortcuts.removeAllForFrame(getMainFrame());
-		
+
 		// ### Persist user settings
 		final Properties appProps = SumatraModel.getInstance().getUserSettings();
 

modules/common-gui/src/main/java/edu/tigers/sumatra/IMainFrameObserver.java

@@ -13,50 +13,44 @@
 
 /**
  * MainFrame observer
- * 
+ *
  * @author AndreR
  */
 public interface IMainFrameObserver
 {
-	
+
 	/**
- *
- */
+	 *
+	 */
 	void onSaveLayout();
-	
-	
+
+
 	/**
- *
- */
+	 *
+	 */
 	void onDeleteLayout();
-	
-	
+
+
 	/**
- *
- */
+	 *
+	 */
 	void onExit();
-	
-	
+
+
 	/**
-	 * 
+	 *
 	 */
 	default void onAbout()
 	{
 	}
-	
-	
+
+
 	/**
 	 * @param filename
 	 */
 	void onLoadLayout(String filename);
-
-
-	/**
- *
- */
-	void onRefreshLayoutItems();
-
-
+
+
 	/**
 	 * @param info
 	 */

modules/common-gui/src/main/java/edu/tigers/sumatra/components/BetterScrollPane.java

@@ -4,9 +4,8 @@
 
 package edu.tigers.sumatra.components;
 
-import java.awt.Component;
-
 import javax.swing.JScrollPane;
+import java.awt.Component;
 
 
 /**
@@ -18,36 +17,15 @@
 public class BetterScrollPane extends JScrollPane
 {
 	private static final int SCROLL_INCREMENT = 16;
-
-
-	public BetterScrollPane()
-	{
-		super();
-		changeDefaults();
-	}
-
-
+
+
 	public BetterScrollPane(Component component)
 	{
 		super(component);
 		changeDefaults();
 	}
-
-
-	public BetterScrollPane(int var1, int var2)
-	{
-		super(var1, var2);
-		changeDefaults();
-	}
-
-
-	public BetterScrollPane(Component component, int var2, int var3)
-	{
-		super(component, var2, var3);
-		changeDefaults();
-	}
-
-
+
+
 	private void changeDefaults()
 	{
 		this.getVerticalScrollBar().setUnitIncrement(SCROLL_INCREMENT); // change vertical scroll speed

modules/common-gui/src/main/java/edu/tigers/sumatra/components/EnumCheckBoxPanel.java

@@ -3,8 +3,16 @@
  */
 package edu.tigers.sumatra.components;
 
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+import javax.swing.BorderFactory;
+import javax.swing.BoxLayout;
+import javax.swing.JButton;
+import javax.swing.JCheckBox;
 import java.awt.event.ItemEvent;
 import java.awt.event.ItemListener;
+import java.io.Serial;
 import java.util.Arrays;
 import java.util.Collections;
 import java.util.Comparator;
@@ -14,15 +22,6 @@
 import java.util.Map;
 import java.util.Set;
 import java.util.function.Function;
-import java.util.stream.Collectors;
-
-import javax.swing.BorderFactory;
-import javax.swing.BoxLayout;
-import javax.swing.JButton;
-import javax.swing.JCheckBox;
-
-import org.apache.logging.log4j.LogManager;
-import org.apache.logging.log4j.Logger;
 
 
 /**
@@ -34,6 +33,7 @@
  */
 public class EnumCheckBoxPanel<T extends Enum<T>> extends BasePanel<EnumCheckBoxPanel.IEnumPanelObserver<T>>
 {
+	@Serial
 	private static final long serialVersionUID = 5263861341015714105L;
 	private static final Logger log = LogManager.getLogger(EnumCheckBoxPanel.class);
 
@@ -99,7 +99,7 @@ private void createBoxes(final int orientation)
 		setLayout(new BoxLayout(this, orientation));
 
 		List<T> sortedEntries = Arrays.stream(enumClass.getEnumConstants())
-				.sorted(Comparator.comparing(Enum::toString)).collect(Collectors.toList());
+				.sorted(Comparator.comparing(Enum::toString)).toList();
 		for (T type : sortedEntries)
 		{
 			JCheckBox checkBox = new JCheckBox(getBoxLabel(type));

modules/sumatra-gui-replay/src/main/java/edu/tigers/sumatra/presenter/replay/ReplayPresenter.java

@@ -330,7 +330,7 @@ private void updateReplayTime()
 			updateEndTime();
 			if (playing)
 			{
-				replayCurTime += ((System.nanoTime() - replayLastTime) * speed);
+				replayCurTime += Math.round((System.nanoTime() - replayLastTime) * speed);
 				if (replayCurTime < 0)
 				{
 					replayCurTime = 0;