Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Stop series download from failing silently #355

Merged
merged 3 commits into from
Sep 11, 2023

Conversation

DESm1th
Copy link
Contributor

@DESm1th DESm1th commented Sep 11, 2023

Recently we've noticed that xnat downloads of some dicom series were failing sporadically. Then, dcm2bids was exporting from the incompletely downloaded data. Our code was then seeing the bids folder for the session and skipping it for future re-extraction attempts causing the data to be missing from the archive until an RA notices and points it out to us.

This fixes this situation by:

  1. Increasing the starting timeout duration for downloads
  2. Fixing a bug that was making our code susceptible to 404 errors after our xnat session timed out
  3. Adding error files to the nii folder when NiiLinkExporter is used, so the missing scans can be reported in the dashboard
  4. Adding a mode to dm_xnat_extract to re-extract using the tmp folder for situations when the bids config changes (unrelated to the above error, but sneaking this enhancement in here since I needed it incidentally while working on CDIA's missing files).

@DESm1th DESm1th requested a review from a team as a code owner September 11, 2023 23:10
@DESm1th DESm1th merged commit ca1a0bb into TIGRLab:main Sep 11, 2023
3 of 5 checks passed
@DESm1th DESm1th deleted the bids_fix branch September 11, 2023 23:10
@github-actions github-actions bot added the fix Tagged PR fixes a bug label Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Tagged PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant