-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Feature/preview #23
base: main
Are you sure you want to change the base?
Conversation
Great, thank you for your pull request @andreasschenkel! 🥳 I will check your revisions for implementing the preview variants out! 😊 |
…ht when using the new example template indian-summer-width
Please have a look at the new template that has just a small change to be able to adjust the width of the image. |
Thank you for all of these ideas and preparations I will review! 😊🙏 Before I have tested the latest work a few thoughts: We have to be careful with some of these points because there are four different ways to load images and it should be the same progress for each of them or otherwise the differences must be taken into account. It's the same with the result: We have 3 different outputs and for example the use of divs within the SVG file will throw errors and the handling with height and width is sensible. So in my opinion it is important to implement these kinds of elements carefully tuned for having a transparent and fully functionally progress for each setting and every enduser. But beyond these thoughts I will try it out! 😊 |
First version to work on #17