Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Feature/preview #23

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

andreasschenkel
Copy link

@andreasschenkel andreasschenkel commented Nov 13, 2023

First version to work on #17

@TRMSC
Copy link
Owner

TRMSC commented Nov 14, 2023

Great, thank you for your pull request @andreasschenkel! 🥳 I will check your revisions for implementing the preview variants out! 😊

@TRMSC TRMSC added the enhancement New feature or request label Nov 14, 2023
@andreasschenkel
Copy link
Author

Please have a look at the new template that has just a small change to be able to adjust the width of the image.
(It is just a div.)
Thus the input image and the generated image have the original width and height but the size can be changed by using this template.
Templates that do not use this additional div will create images with a width of 100%.

@TRMSC
Copy link
Owner

TRMSC commented Nov 14, 2023

Thank you for all of these ideas and preparations I will review! 😊🙏

Before I have tested the latest work a few thoughts:

We have to be careful with some of these points because there are four different ways to load images and it should be the same progress for each of them or otherwise the differences must be taken into account.

It's the same with the result: We have 3 different outputs and for example the use of divs within the SVG file will throw errors and the handling with height and width is sensible.

So in my opinion it is important to implement these kinds of elements carefully tuned for having a transparent and fully functionally progress for each setting and every enduser.

But beyond these thoughts I will try it out! 😊

This was referenced Nov 18, 2023
TRMSC added a commit that referenced this pull request Nov 19, 2023
TRMSC added a commit that referenced this pull request Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants