Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FasterNomNotifications! #383

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Lilly-Lira
Copy link
Collaborator

The powers is within u

The powers is within u
@Arokha
Copy link
Contributor

Arokha commented Jun 19, 2024

When you discussed this you said "For vore deaths", this will apply to all deaths or even just manual ghosting, so someone could manually ghost and immediately ping with this change.

To explain what's happening, the reason you can't immediately ping is because there's two time-sensitive events happening. One is the transcore sweeping over the backup implants every n minutes, and checking when the implant last sent a ping. If it's greater than the overdue time, it marks them as dead (transcore_vr.dm:120). At that point you can immediately use the notify verb.

The other time sensitive thing is that if you died more than 5 minutes ago, this proc you're editing allows you to ping if for some reason the transcore didn't mark you as dead. That should never really happen, the transcore sweeps happen more often than every 5 minutes I believe, but this is meant more as a catch-all thing for situations where the transcore sweeps stop happening (like the subsystem breaks or whatever).

What might be better for what you want, assuming you want it "for vore deaths", is to just manually set the record to MR_DEAD on gurgle death. That way the verb is immediately usable by them, but not by manual ghosts, people who died in space, etc. They have to wait a few minutes.

To help, the proc you modified here has the way to grab the current gurleee's record: var/datum/transhuman/mind_record/record = db.backed_up[src.mind.name] and then you would just set record.dead_state = MR_DEAD. You could just add that in some spot that happens whenever vore deaths do, like in the digestion proc or whatever. (You don't want src though probably, you want a reference to the gurgleee)

@Lilly-Lira
Copy link
Collaborator Author

Thanks! This seems like a better way to do it. I will update :3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants