Add Crashlytics (#746)

* Add Crashlytics and remove our own bug reporting

app/build.gradle

@@ -5,6 +5,7 @@ plugins {
 apply plugin: 'com.android.application'
 apply plugin: 'kotlin-android'
 apply plugin: 'kotlin-android-extensions'
+apply plugin: 'io.fabric'
 apply from: '../findbugs.gradle'
 apply from: '../pmd.gradle'
 apply from: '../jacoco.gradle'
@@ -120,6 +121,7 @@ dependencies {
     annotationProcessor "android.arch.persistence.room:compiler:$roomVersion"
     implementation "com.google.android.gms:play-services-location:$firebaseVersion"
     implementation 'com.android.support.constraint:constraint-layout:1.0.2'
+    implementation 'com.crashlytics.sdk.android:crashlytics:2.9.1'
 
     //DB Debugging: adb forward tcp:8080 tcp:8080 - look for DebugDB in logcat
     debugImplementation 'com.amitshekhar.android:debug-db:1.0.3'

app/src/main/java/de/tum/in/tumcampusapp/api/app/Helper.java

@@ -12,7 +12,6 @@
 
 import java.util.concurrent.TimeUnit;
 
-import de.tum.in.tumcampusapp.component.other.reporting.bugreport.G;
 import de.tum.in.tumcampusapp.utils.Utils;
 import okhttp3.CertificatePinner;
 import okhttp3.Interceptor;
@@ -76,15 +75,8 @@ public static OkHttpClient getOkClient(Context c) {
 
     private static Interceptor getDeviceInterceptor(final Context c) {
         //Clearly identify all requests from this app
-        final StringBuilder userAgent = new StringBuilder("TCA Client");
-        if (G.appVersion != null && !G.appVersion.equals(G.UNKNOWN)) {
-            userAgent.append(' ')
-                     .append(G.appVersion);
-            if (G.appVersionCode != -1) {
-                userAgent.append('/')
-                         .append(G.appVersionCode);
-            }
-        }
+        final StringBuilder userAgent = new StringBuilder("TCA Client ");
+        userAgent.append(Utils.getAppVersion(c));
 
         return chain -> {
             Utils.log("Fetching: " + chain.request()

app/src/main/java/de/tum/in/tumcampusapp/api/app/TUMCabeAPIService.java

@@ -6,7 +6,6 @@
 import de.tum.in.tumcampusapp.api.app.model.DeviceUploadGcmToken;
 import de.tum.in.tumcampusapp.api.app.model.TUMCabeStatus;
 import de.tum.in.tumcampusapp.component.other.locations.model.BuildingToGps;
-import de.tum.in.tumcampusapp.component.other.reporting.bugreport.model.BugReport;
 import de.tum.in.tumcampusapp.component.other.reporting.stats.model.Statistics;
 import de.tum.in.tumcampusapp.component.other.wifimeasurement.model.WifiMeasurement;
 import de.tum.in.tumcampusapp.component.tumui.feedback.model.Feedback;
@@ -57,7 +56,6 @@
 import static de.tum.in.tumcampusapp.api.app.TUMCabeClient.API_KINOS;
 import static de.tum.in.tumcampusapp.api.app.TUMCabeClient.API_LOCATIONS;
 import static de.tum.in.tumcampusapp.api.app.TUMCabeClient.API_NOTIFICATIONS;
-import static de.tum.in.tumcampusapp.api.app.TUMCabeClient.API_REPORT;
 import static de.tum.in.tumcampusapp.api.app.TUMCabeClient.API_ROOM_FINDER;
 import static de.tum.in.tumcampusapp.api.app.TUMCabeClient.API_ROOM_FINDER_AVAILABLE_MAPS;
 import static de.tum.in.tumcampusapp.api.app.TUMCabeClient.API_ROOM_FINDER_COORDINATES;
@@ -124,10 +122,6 @@ public interface TUMCabeAPIService {
     @GET(API_LOCATIONS + "{locationId}/")
     Call<GCMNotificationLocation> getLocation(@Path("locationId") int locationId);
 
-    //Bug Reports
-    @PUT(API_REPORT)
-    Call<List<String>> putBugReport(@Body BugReport r);
-
     //Statistics
     @PUT(API_STATISTICS)
     Call<List<String>> putStatistics(@Body Statistics r);

app/src/main/java/de/tum/in/tumcampusapp/api/app/TUMCabeClient.java

@@ -14,7 +14,6 @@
 import de.tum.in.tumcampusapp.api.app.model.DeviceUploadGcmToken;
 import de.tum.in.tumcampusapp.api.app.model.TUMCabeStatus;
 import de.tum.in.tumcampusapp.component.other.locations.model.BuildingToGps;
-import de.tum.in.tumcampusapp.component.other.reporting.bugreport.model.BugReport;
 import de.tum.in.tumcampusapp.component.other.reporting.stats.model.Statistics;
 import de.tum.in.tumcampusapp.component.other.wifimeasurement.model.WifiMeasurement;
 import de.tum.in.tumcampusapp.component.tumui.feedback.model.Feedback;
@@ -51,15 +50,17 @@
 import retrofit2.converter.gson.GsonConverterFactory;
 import retrofit2.http.Body;
 
-public class TUMCabeClient {
+/**
+ * Proxy class for Retrofit client to our API hosted @app.tum.de
+ */
+public final class TUMCabeClient {
 
-    static final String API_HOSTNAME = Const.API_HOSTNAME;
-    static final String API_BASEURL = "/Api/";
-    static final String API_CHAT = "chat/";
+    private static final String API_HOSTNAME = Const.API_HOSTNAME;
+    private static final String API_BASEURL = "/Api/";
+    private static final String API_CHAT = "chat/";
     static final String API_CHAT_ROOMS = API_CHAT + "rooms/";
     static final String API_CHAT_MEMBERS = API_CHAT + "members/";
     static final String API_CURRICULA = "curricula/";
-    static final String API_REPORT = "report/";
     static final String API_STATISTICS = "statistics/";
     static final String API_NOTIFICATIONS = "notifications/";
     static final String API_LOCATIONS = "locations/";
@@ -207,12 +208,6 @@ public GCMNotificationLocation getLocation(int locationId) throws IOException {
                       .body();
     }
 
-    public void putBugReport(BugReport r) throws IOException {
-        service.putBugReport(r)
-               .execute()
-               .body();
-    }
-
     public void putStatistics(Statistics s) {
         service.putStatistics(s)
                .enqueue(new Callback<List<String>>() {