feat:Implemented Base Grade Notification Hook Service #181
Conversation
|
@joschahenningsen Small ping ;) |
|
@joschahenningsen Small ping v2 ;) |
CommanderStorm
changed the title
There was a problem hiding this comment.
Overall, I have not found anything controversial.
What I find interesting is that you use a lot more patterns (especially service+repository) than the rest of the project.
Do you think that would be a concept that we could discuss on the next team meeting (as I think this could be generally usefull to learn about)
...kend/new_exam_results_hook/new_exam_results_scheduling/newExamResultsSchedulingRepository.go
Outdated
Show resolved
Hide resolved
...backend/new_exam_results_hook/new_exam_results_scheduling/newExamResultsSchedulingService.go
Outdated
Show resolved
Hide resolved
...kend/new_exam_results_hook/new_exam_results_subscriber/newExamResultsSubscriberRepository.go
Show resolved
Hide resolved
...kend/new_exam_results_hook/new_exam_results_subscriber/newExamResultsSubscriberRepository.go
Outdated
Show resolved
Hide resolved
...kend/new_exam_results_hook/new_exam_results_subscriber/newExamResultsSubscriberRepository.go
Outdated
Show resolved
Hide resolved
…' into feature/new-grade-published-hook
=> moved CAMPUS_API_TOKEN into .env
# Conflicts: # .env # server/backend/campus_api/campusApi.go # server/backend/migration/migration.go # server/model/crontab.go
...kend/new_exam_results_hook/new_exam_results_subscriber/newExamResultsSubscriberRepository.go
Outdated
Show resolved
Hide resolved
...kend/new_exam_results_hook/new_exam_results_subscriber/newExamResultsSubscriberRepository.go
Outdated
Show resolved
Hide resolved
|
@Antonwy
How do I create an account independant Token? Ask Andi? |
Yes exactly would probably check with Andy what's the best next step here or if he can already provide a token! |
Hook service for new Grades
Checks the
pruefungenErgebnisseendpoint every minute and notifies hook subscribers if there is a new grade.Next
Add iOS subscriber that sends push notification.