feat(feedback-api):Sending feedback-mails #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CommanderStorm
force-pushed
the
feature/feedback-api
branch
2 times, most recently
from
ee998a2 to
3f76b91
Compare
CommanderStorm
force-pushed
the
feature/feedback-api
branch
3 times, most recently
from
50dbe41 to
32646d9
Compare
CommanderStorm
changed the title
CommanderStorm
changed the title
CommanderStorm
force-pushed
the
feature/feedback-api
branch
from
9200fcb to
0224da9
Compare
CommanderStorm
force-pushed
the
feature/feedback-api
branch
from
adc2e82 to
366a515
Compare
CommanderStorm
force-pushed
the
feature/feedback-api
branch
from
366a515 to
a740c95
Compare
|
I like the idea, the other option is to use transactional emails, that usually come at a cost (like sendgrid) |
kordianbruck
reviewed
Oct 1, 2023
# Conflicts: # client/go.mod # client/go.sum
kordianbruck
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to send feedback mails via a cronjob.
I am currently unsure if this was a good call.
The advantage of the cron-appoach is that we can get around temporary network obstructions via automatically retrying and decouples the streaming feedback api from this step.
Testing that this works is done via the included unit tests