chore:news testing #216
Merged
chore:news testing #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CommanderStorm
force-pushed
the
chore/news-testing
branch
from
9ec3a3b to
e135cd8
Compare
… moved all news entries to a separate file for better testing
CommanderStorm
force-pushed
the
chore/news-testing
branch
from
e135cd8 to
81e2307
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests to the news APIs and fixes the following defects:
GetNewsSourcespreviously did not join with other tables and instead requested more information via additional queriesGetNewsSourcespreviously did join with a non-existing table (Company) resulting in a broken queryGetNewsSourcespreviously did not fill out all fields returned correctlyNewsSourceArraywas not namedNewsSourceReplylike the other responses