Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore:no empty #233

Merged
merged 2 commits into from
Sep 19, 2023
Merged

chore:no empty #233

merged 2 commits into from
Sep 19, 2023

Conversation

CommanderStorm
Copy link
Member

This removes all instances of empty from our API as noticed in #219 (comment)

Try to avoid Empty as changing it to an actual Request payload is not compatible on the wire format and might cause incompatibility if we want to extend this later on.

Because field types are also used to determine when the receiver ends a field, changing field types across versions without carefully checking for compatibility can also cause problems. There are many specific rules about how to change field types, but a good standard is to avoid ever changing the wire type of any field. If you’re in a situation where you need to change a field type, the best path forward is to deprecate the existing field and put the new information into a new field.

https://earthly.dev/blog/backward-and-forward-compatibility/

@CommanderStorm CommanderStorm merged commit 64ca208 into main Sep 19, 2023
2 of 3 checks passed
@CommanderStorm CommanderStorm deleted the chore/no-empty branch September 19, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant