Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug:file download #237

Merged
merged 7 commits into from
Sep 21, 2023
Merged

bug:file download #237

merged 7 commits into from
Sep 21, 2023

Conversation

CommanderStorm
Copy link
Member

While the concrete bug causing our backend to shut down is not quite apparent, this might shed a bit more information.

Concrete changes:

  • updating the downloads field
  • wrapping the whole thing in a transaction
  • Separating functions into testable units and adding tests
  • not downloading large files to memory and then dumping them to file (instead download them to file and then read them) ^^
  • making sure that already existing and not as finished marked files (i.e. partial downloads) are correctly handled

@CommanderStorm CommanderStorm enabled auto-merge (squash) September 21, 2023 23:38
@CommanderStorm CommanderStorm merged commit 892c29b into main Sep 21, 2023
3 checks passed
@CommanderStorm CommanderStorm deleted the bug/file-download branch September 21, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant