Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to filter by oldest date #255

Merged
merged 3 commits into from
Oct 9, 2023
Merged

Conversation

CommanderStorm
Copy link
Member

This resolves the following suggestion by @jakobkoerber

Hätte auch ein Proposal für den Movie Endpoint - wäre es nicht auch praktisch, wenn man das aktuelle Datum per Parameter schicken könnte und das Backend nur Filme nach oder an diesem Datum zurückgibt? Gleiches könnte auch für News gelten, um zum Beispiel nur die News der letzten 30 Tage zu fetchen

@jakobkoerber
Copy link
Member

Thanks for implementing that so quickly! Appreciate it @CommanderStorm 🙏

Copy link
Collaborator

@tobiasjungmann tobiasjungmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in my opinion, just one tiny nit: in news_test all querys but the first one are renamed to the new naming scheme. It is still called "ExpectedGetSourceQuery" instead of "ExpectedListSourceQuery" :D

@CommanderStorm CommanderStorm merged commit 1a7f37e into main Oct 9, 2023
@CommanderStorm CommanderStorm deleted the feat/oldest_date_at branch October 9, 2023 13:35
@CommanderStorm
Copy link
Member Author

I am going to interpretet your LGTM as "can be merged" despite the requested changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants