Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/refactored protofile #270

Closed
wants to merge 4 commits into from
Closed

Chore/refactored protofile #270

wants to merge 4 commits into from

Conversation

CommanderStorm
Copy link
Member

This PR is more of a discussion:
Should we separate the services we have in our proto file?

Current New
image image

@CommanderStorm CommanderStorm self-assigned this Oct 22, 2023
@kordianbruck
Copy link
Member

From personal chat:

  • I'm not clear on the technical benefits here. We seemingly increase complexity in client management (now have several separate clients and TCP sockets) to increase a bit the readability in the swagger docs (which is nice though!).
  • It would make monitoring a bit nicer.
  • Backend complexity could be handled better by setting coding guidelines and patterns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kordianbruck kordianbruck Awaiting requested review from kordianbruck

@tobiasjungmann tobiasjungmann Awaiting requested review from tobiasjungmann

Assignees

@CommanderStorm CommanderStorm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CommanderStorm @kordianbruck