Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make icons ("sprites") colored #1637

Closed
CommanderStorm opened this issue Oct 29, 2024 · 4 comments · Fixed by #1648
Closed

Make icons ("sprites") colored #1637

CommanderStorm opened this issue Oct 29, 2024 · 4 comments · Fixed by #1648
Labels
feature New feature or request good first issue Good for newcomers

Comments

@CommanderStorm
Copy link
Member

Is your feature request related to a problem? Please describe.
Currently, the icons are only partially colored
image

Describe the solution you'd like
Since maplibre/martin#1492 was merged, we have the ability to color our sprites.
I have already colored the "most important" (transit, parking, food-stuff) icons, but there is still a lot of work left to do.

What is missing concretely:

  • add a style for poi_activity containing the
  • move the "lower priority"-icons (hotels, shops, ...) to a brown icon layer po_
  • look at the console if any icons are missing / wrongly defined
  • remove the legacy/black icons

Additional context

Tip

Use the inspect view at the top of the map and look what data exists ^^

@CommanderStorm CommanderStorm added feature New feature or request good first issue Good for newcomers labels Oct 29, 2024
@BaumBanane
Copy link
Contributor

BaumBanane commented Oct 30, 2024

svg-Dateien für S-Bahn und U-Bahn:

sbahn U-Bahn
sbahn U-Bahn

@CommanderStorm
Copy link
Member Author

@BaumBanane Before we forget this (and because it would be very pretty/ and was as a lot of work):
Could you link the work you/we did on the coding night regarding poi-styling? ^^

@RisGar
Copy link
Contributor

RisGar commented Nov 3, 2024

@CommanderStorm Ich hätte einem commit/pr fertig, nur habe ich noch nicht herausgefunden wie das Styling getestet werden kann, da die docker compose Datei sich die Daten von nav.tum.de zieht.

@CommanderStorm
Copy link
Member Author

"Testing" vom karten-stil im style-editor passt total. 😅
Das muss man nicht verkomplizieren..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants