New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add different colours to sprites in map style #1648

Merged

CommanderStorm merged 1 commit into TUM-Dev:main from RisGar:main

Nov 3, 2024

Contributor

RisGar commented Nov 3, 2024 •

edited

Loading

Fixes #1637

Proposed Changes (include Screenshots if possible)

Replace "poi_z14+" layers in map style with "poi_category" layers
Add colours to all different layers based on provided style reference

How to test this PR

Upload navigatum-basemap.json into Maputnik

How has this been tested?

Style is directly exported from Maputnik and is functional in the viewer
All major TUM locations have been checked in Maputnik

Checklist

~~I have updated the documentation~~ / No need to update the documentation
I have run the linter


          feat(map): colour map icons

5cba7b4

Co-authored-by: BaumBanane <[email protected]>

Contributor Author

RisGar commented Nov 3, 2024

Regarding the colour of the "poi_food" layer: Is the text comfortably readable or should it be darker?

CommanderStorm approved these changes

View reviewed changes

Member

CommanderStorm left a comment

Looks great! 🎉

Re: color of the food-icons, I think this is fine ^^

CommanderStorm merged commit 24c1a56 into TUM-Dev:main

5 of 7 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet