Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/inline feedback #1118

Merged
merged 10 commits into from
Apr 28, 2024
Merged

Chore/inline feedback #1118

merged 10 commits into from
Apr 28, 2024

Conversation

CommanderStorm
Copy link
Member

Proposed Changes (include Screenshots if possible)

  • Last part of inlinig the feedback into the same executable as the main api

How to test this PR

  1. Test it in prod, its saturda evening.. nobody cares..

How has this been tested?

  • it compiles
  • and we are going to see if I made a mistake in prod

Checklist

  • I have updated the documentation / No need to update the documentation
  • I have run the linter

@CommanderStorm CommanderStorm enabled auto-merge (squash) April 28, 2024 01:08
@CommanderStorm CommanderStorm merged commit e3e2d37 into main Apr 28, 2024
16 checks passed
@CommanderStorm CommanderStorm deleted the chore/inline-feedback branch April 28, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant