Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON based generated database fields instead of imports #1155

Merged
merged 11 commits into from
May 7, 2024
Merged

JSON based generated database fields instead of imports #1155

merged 11 commits into from
May 7, 2024

Conversation

CommanderStorm
Copy link
Member

@CommanderStorm CommanderStorm commented May 6, 2024 •
edited
Loading

Needs #1154

Proposed Changes (include Screenshots if possible)

  • migrates the database fields to use generated json fields
  • removes the relevant part of the setup script

How to test this PR

  1. reset the db
  2. run the setup (incl migrations)
  3. run the webclient
  4. see the existing api still working

How has this been tested?

  • see above

Checklist

  • I have updated the documentation / No need to update the documentation
  • I have run the linter

@CommanderStorm CommanderStorm marked this pull request as ready for review May 7, 2024 15:05
@CommanderStorm CommanderStorm enabled auto-merge (squash) May 7, 2024 15:05
@CommanderStorm CommanderStorm merged commit 93e6a80 into main May 7, 2024
14 checks passed
@CommanderStorm CommanderStorm deleted the json-db branch May 7, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@CommanderStorm