Made sure that Meilisearch initalisation does not have gaps #1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CommanderStorm
force-pushed
the
better-ms-init
branch
from
71337be to
793b18c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current meilisearch initialisation logic has a gap (~2-5s) where we might serve out EMPTY search results.
The client treats these as valid => won't retry them and might cache them
Related to @AntonMC-Github's discoveries (thanks for the report) in #1274
Proposed Changes (include Screenshots if possible)
tokyo::RWLockprevents the database to be in an invalid stat during searchesdb->poolto relflect the usageHow to test this PR
How has this been tested?
Checklist