made sure that the rust based deserialiser is implemented #1611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CommanderStorm
force-pushed
the
rust-based-decoder
branch
from
b8b6d06 to
7a8edfe
Compare
CommanderStorm
force-pushed
the
rust-based-decoder
branch
2 times, most recently
from
a2fae63 to
589539e
Compare
CommanderStorm
force-pushed
the
rust-based-decoder
branch
from
2c68f76 to
bd6c9a8
Compare
CommanderStorm
commented
Nov 2, 2024
There was a problem hiding this comment.
This rips out the "shaddow-api" (which kind of exists, but is not documented)
None of the clients use this part of the API.
@jakobkoerber I have verified this with the limited subset here
https://github.com/TUM-Dev/campus_flutter/blob/main/lib/navigaTumComponent/model/details/navigatum_navigation_additional_properties.dart#L8-L9
https://github.com/TUM-Dev/campus_flutter/blob/2d544148695881ef7c99bcba318d15ab81c42ed5/lib/navigaTumComponent/model/navigatum_navigation_details.dart#L10-L21
CommanderStorm
commented
Nov 2, 2024
CommanderStorm
commented
Nov 2, 2024
CommanderStorm
commented
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1325, we will eventually need to switch the backend to be more competent.
This PR makes solidifies the output format to enable less scary reworking on the data side