Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cal-12] Replacement of internal API calls with the CDN #637

Merged
merged 7 commits into from
Jun 3, 2023
Merged

[Cal-12] Replacement of internal API calls with the CDN #637

merged 7 commits into from
Jun 3, 2023

Conversation

CommanderStorm
Copy link
Member

@CommanderStorm CommanderStorm commented May 28, 2023 •
edited
Loading

Fixes:

  • The URL given out by the calendar API not correlating with the selected enty (noticed while implementing [Cal-13] Calendar Frontend #472)
  • There being an internal API route

Proposed Changes (include Screenshots if possible)

  • Replaced the internal API call by parsing the json of the CDN.

How to test this PR

  • code review

How has this been tested?

  1. docker run -p 5432:5432 --name some-postgres -e POSTGRES_PASSWORD=password -d postgres
  2. export SCRAPED_TIME_WINDOW_MONTHS=1
  3. cargo run --bin navigatum-calendar-scraper

Checklist:

  • I have updated the documentation / No need to update the documentation
  • I have run the linter

@CommanderStorm CommanderStorm self-assigned this May 28, 2023
@github-actions
Copy link
Contributor

👋 Thank you for contributing. A staging environment for this PR for this change will be available shortly

github-actions bot added a commit that referenced this pull request May 28, 2023
@github-actions
Add deployment for PR #637
b4dd734
@CommanderStorm CommanderStorm changed the title Replacement of internal API calls with Replacement of internal API calls with the CDN May 29, 2023
@CommanderStorm CommanderStorm changed the title Replacement of internal API calls with the CDN [Cal-12] Replacement of internal API calls with the CDN May 29, 2023
@CommanderStorm CommanderStorm mentioned this pull request May 29, 2023
Merged
3 tasks
@CommanderStorm CommanderStorm marked this pull request as ready for review June 3, 2023 18:19
@CommanderStorm CommanderStorm merged commit 6a05492 into main Jun 3, 2023
@CommanderStorm CommanderStorm deleted the no_internals branch June 3, 2023 18:21
github-actions bot added a commit that referenced this pull request Jun 3, 2023
@github-actions
Removed the deployment for PR #637
2d0cc68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@CommanderStorm CommanderStorm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@CommanderStorm