-
Notifications
You must be signed in to change notification settings - Fork 44
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Added help icons to some admin pages and fixed worker pipeline for gi…
…thub to show current version instead of version sha
- Loading branch information
Showing
9 changed files
with
62 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -414,4 +414,4 @@ label:has(~ .tum-live-input) { | |
|
||
.tum-live-markdown a { | ||
border-bottom: 1px solid black; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
import * as help from "./help-icon"; | ||
|
||
export function defineElements() { | ||
customElements.define("help-icon", help.HelpIcon); | ||
console.log("Defined custom elements"); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
export class HelpIcon extends HTMLElement { | ||
private text: string; | ||
constructor() { | ||
super(); | ||
} | ||
|
||
connectedCallback() { | ||
this.text = this.getAttribute("text") ?? "No help available"; | ||
this.innerHTML = ` | ||
<style> | ||
.help-icon-tooltip-desktop { | ||
max-width: 22rem; | ||
} | ||
</style> | ||
<span | ||
x-data="{ tooltip: false }" | ||
x-on:mouseover="tooltip = true" | ||
x-on:mouseleave="tooltip = false" | ||
class="cursor-pointer m-0 pl-1 text-sm"> | ||
<i class="fa-solid fa-circle-info text-gray-700 dark:text-gray-400 w-fit h-fit justify-self-center"></i> | ||
<div x-show="tooltip" | ||
class="text-sm help-icon-tooltip-desktop text-white absolute primary rounded-lg p-1.5" | ||
> | ||
${this.text} | ||
</div> | ||
</span> | ||
`; | ||
this.className = "m-0 p-0 text-xs"; | ||
this.style.textRendering = ""; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
/* This bundle contains all functionality that students depend on when not watching a video */ | ||
export * from "../global"; | ||
export * from "../course-overview"; | ||
export * from "../course-overview"; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
395ddc7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! I think the admin pages with help-icons would be really helpful. I'm also working on the admin pages, and I'd like to write down my thoughts on the help icons here, when I had any.
For now I'm considering about the slug on the create-course page. I'm changing its behaviour, so that only such characters would be accepted: A-Z, a-z, 0-9, and some of the URL-safe special characters "-_.+()~". I think this should be enough for a course slug...
I think a help icon is needed for the slug, and the help information should include the following: